Skip to content

Add privKeySet checks to Ed25519, Ed448, ML-DSA, and ML-KEM#10083

Merged
douzzer merged 2 commits intowolfSSL:masterfrom
anhu:privkeyset
Apr 2, 2026
Merged

Add privKeySet checks to Ed25519, Ed448, ML-DSA, and ML-KEM#10083
douzzer merged 2 commits intowolfSSL:masterfrom
anhu:privkeyset

Conversation

@anhu
Copy link
Copy Markdown
Member

@anhu anhu commented Mar 26, 2026

Fixes:
ZD 21437
ZD 21440
ZD 21438
ZD 21441

@anhu anhu self-assigned this Mar 26, 2026
@anhu anhu requested a review from wolfSSL-Bot March 26, 2026 18:59
@anhu
Copy link
Copy Markdown
Member Author

anhu commented Mar 26, 2026

jenkins retest this please

@Frauschi Frauschi added the For This Release Release version 5.9.1 label Mar 30, 2026
Frauschi
Frauschi previously approved these changes Mar 30, 2026
@anhu anhu assigned wolfSSL-Bot and unassigned anhu Mar 30, 2026
@douzzer douzzer added Staged Staged for merge pending final test results and review and removed Staged Staged for merge pending final test results and review labels Mar 30, 2026
Copy link
Copy Markdown
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing FIPS gates on new test coverage. Need #if !defined(HAVE_FIPS) || FIPS_VERSION3_GE(7,0,0).

[linuxkm-defaults-all-fips-v6-sanitizer] [43 of 61] [4f295cfb83]
    setting up FIPS "v6-linuxkm"... 
    refreshing fips WCv6.0.0-linuxkm-UPDT-RC3... [caching link to git@github.com... done]  done, now at 7756dbea90
    setting up FIPS "v6-linuxkm"...     refreshing wolfssl WCv6.0.0-linuxkm-UPDT-RC2... done, now at b7220aeb4b
done [fips="WCv6.0.0-linuxkm-UPDT-RC3" (7756dbea90), wolfCrypt="WCv6.0.0-linuxkm-UPDT-RC2" (def685129c)]
    configure${config_analyzer_note}...   real 0m10.034s  user 0m6.581s  sys 0m4.288s
    build...   real 0m39.253s  user 8m11.417s  sys 0m9.459s
    fixing FIPS hash in user library... done.
    check...FAIL: scripts/unit.test
   real 1m23.571s  user 2m0.943s  sys 0m16.164s
ERROR - tests/api/test_ed25519.c line 206 failed with:
    expected: wc_ed25519_sign_msg_fips(msg, sizeof(msg), sig, &sigLen, &pubOnlyKey) == (BAD_FUNC_ARG)
    result:   0 != -173
ERROR - tests/api.c line 36011 failed with:
    expected: Test failed
    result:   ret 0
ERROR - tests/api/test_ed448.c line 199 failed with:
    expected: wc_ed448_sign_msg_fips(msg, sizeof(msg), sig, &sigLen, &pubOnlyKey, ((void *)0), 0) == (BAD_FUNC_ARG)
    result:   0 != -173
ERROR - tests/api.c line 36011 failed with:
    expected: Test failed
    result:   ret 0

@anhu anhu removed their assignment Apr 1, 2026
@anhu anhu requested a review from douzzer April 1, 2026 13:44
@anhu
Copy link
Copy Markdown
Member Author

anhu commented Apr 1, 2026

jenkins retest this please

1 similar comment
@anhu
Copy link
Copy Markdown
Member Author

anhu commented Apr 1, 2026

jenkins retest this please

@douzzer douzzer added the Staged Staged for merge pending final test results and review label Apr 1, 2026
@douzzer douzzer merged commit 5701f5d into wolfSSL:master Apr 2, 2026
512 of 963 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.1 Staged Staged for merge pending final test results and review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants