Add privKeySet checks to Ed25519, Ed448, ML-DSA, and ML-KEM#10083
Merged
douzzer merged 2 commits intowolfSSL:masterfrom Apr 2, 2026
Merged
Add privKeySet checks to Ed25519, Ed448, ML-DSA, and ML-KEM#10083douzzer merged 2 commits intowolfSSL:masterfrom
douzzer merged 2 commits intowolfSSL:masterfrom
Conversation
Member
Author
|
jenkins retest this please |
Frauschi
previously approved these changes
Mar 30, 2026
douzzer
requested changes
Mar 31, 2026
Contributor
douzzer
left a comment
There was a problem hiding this comment.
Missing FIPS gates on new test coverage. Need #if !defined(HAVE_FIPS) || FIPS_VERSION3_GE(7,0,0).
[linuxkm-defaults-all-fips-v6-sanitizer] [43 of 61] [4f295cfb83]
setting up FIPS "v6-linuxkm"...
refreshing fips WCv6.0.0-linuxkm-UPDT-RC3... [caching link to git@github.com... done] done, now at 7756dbea90
setting up FIPS "v6-linuxkm"... refreshing wolfssl WCv6.0.0-linuxkm-UPDT-RC2... done, now at b7220aeb4b
done [fips="WCv6.0.0-linuxkm-UPDT-RC3" (7756dbea90), wolfCrypt="WCv6.0.0-linuxkm-UPDT-RC2" (def685129c)]
configure${config_analyzer_note}... real 0m10.034s user 0m6.581s sys 0m4.288s
build... real 0m39.253s user 8m11.417s sys 0m9.459s
fixing FIPS hash in user library... done.
check...FAIL: scripts/unit.test
real 1m23.571s user 2m0.943s sys 0m16.164s
ERROR - tests/api/test_ed25519.c line 206 failed with:
expected: wc_ed25519_sign_msg_fips(msg, sizeof(msg), sig, &sigLen, &pubOnlyKey) == (BAD_FUNC_ARG)
result: 0 != -173
ERROR - tests/api.c line 36011 failed with:
expected: Test failed
result: ret 0
ERROR - tests/api/test_ed448.c line 199 failed with:
expected: wc_ed448_sign_msg_fips(msg, sizeof(msg), sig, &sigLen, &pubOnlyKey, ((void *)0), 0) == (BAD_FUNC_ARG)
result: 0 != -173
ERROR - tests/api.c line 36011 failed with:
expected: Test failed
result: ret 0
Member
Author
|
jenkins retest this please |
1 similar comment
Member
Author
|
jenkins retest this please |
douzzer
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
ZD 21437
ZD 21440
ZD 21438
ZD 21441